Skip to content

[stdlib] Add Sequence.allSatisfy #15120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2018

Conversation

airspeedswift
Copy link
Member

@airspeedswift airspeedswift commented Mar 9, 2018

Implementation for swiftlang/swift-evolution#799

@airspeedswift
Copy link
Member Author

@swift-ci please test

@airspeedswift airspeedswift changed the title [stdlib][DNM] Add Sequence.containsOnly [stdlib] Add Sequence.allSatisfy Apr 27, 2018
@airspeedswift
Copy link
Member Author

@swift-ci please test

@airspeedswift airspeedswift requested a review from moiseev April 27, 2018 16:26
Copy link
Contributor

@moiseev moiseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm a little worried about the performance though. Would sleep better knowing for sure this implementation is as efficient after optimizations as a naïve for loop.

@airspeedswift
Copy link
Member Author

Oops your comment reminded me I needed to de-underscore inlinnnnnable

@airspeedswift
Copy link
Member Author

@swift-ci please smoke test and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants