Begin refactoring type variable binding code. #15128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all the code specific to dealing with relational constraints out into a separate function. I expect to do more refactoring here so this is likely not the final form for this code - just one step in the direction of breaking things down into smaller logical pieces.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
Hmm, @vedantk have any ideas on this Linux failure? |
|
I've been seeing some build failures locally after the transition branch was merged into stable, but Fred hasn't. I think one of the failures can be resolved by wiping the build directory. @shahmishal is there some way we could do that on the bot? |
|
@swift-ci Please clean smoke test |
|
Linux build timeout after 300 minutes |
|
@swift-ci Please clean smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all the code specific to dealing with relational constraints out
into a separate function.
I expect to do more refactoring here so this is likely not the final
form for this code - just one step in the direction of breaking things
down into smaller logical pieces.