Clear any LLVMArgs when initializing the CompilerInvocation for SourceKit's ASTManager #15135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eKit's ASTManager SourceKit doesn't use them and if any unrecognised LLVM options are passed to llvm::cl::ParseCommandLineOptions() it calls exit(), bringing down SourceKit. Also use fprintf instead of llvm::errs() in Logging.cpp as it uses a global C++ object that had already been destructed when logging the above failure. Resolves rdar://problem/38314383
nathawes
force-pushed
the
rdar38314383-ignore-llvm-args-for-sourcekit-ast-manager-invocation
branch
from
90d28c3 to
17a6ef5
Compare
|
@swift-ci please test and merge |
|
@swift-ci please test linux |
nathawes
deleted the
rdar38314383-ignore-llvm-args-for-sourcekit-ast-manager-invocation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceKit doesn't use them and if any unrecognised LLVM options are passed to
llvm::cl::ParseCommandLineOptions()it callsexit(), bringing down SourceKit.Also use
fprintfin Logging.cpp instead ofllvm::errs()which uses a global C++ object that had already been destructed when logging the above failure.Resolves rdar://problem/38314383