[Parse] Reduce branches by running lexTrivia always #15137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
reviewed
Mar 10, 2018
rintaro
approved these changes
Mar 10, 2018
rintaro
reviewed
Mar 10, 2018
| goto Restart; // Skip presumed whitespace. | ||
| assert( | ||
| ShouldTokenize && | ||
| "Invalid UTF-8 sequence should be eaten by lexTrivia as LeadingTrivia"); |
There was a problem hiding this comment.
This may cause unused variable warning in --no-assertion build. Please add (void)ShouldTokenize; line here.
|
I confirmed warning and updated. |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduce branches in Lexer by running
lexTriviaalways for leading trivia inlexImpl.Especially,
Restartlabel and loop flow also eliminated inlexImpl.For compatibility to current result with
WithoutTrivia,LeadingTriviaandTrailingTriviaare filter out inlex.And skip
lexTriviafor trailing trivia informTokenifWithoutTrivia.By our recently achievement of perfect trivia lexing (and diagnostics),
we don't need trivia skipping logic in
lexImplanymore.The idea of this PR got from my previous PR and conversation with @rintaro about it.
#15081