Skip to content

[Dispatch][gardening] Use Optional.map over flatMap where appropriate #15142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Mar 10, 2018

@ikesyo
Copy link
Member Author

ikesyo commented Mar 10, 2018

@swift-ci smoke test

@ikesyo
Copy link
Member Author

ikesyo commented Mar 10, 2018

This should also be applied to swift-corelibs-libdispatch.

@ikesyo
Copy link
Member Author

ikesyo commented Mar 10, 2018

Submitted swiftlang/swift-corelibs-libdispatch#346.

@ikesyo
Copy link
Member Author

ikesyo commented Mar 16, 2018

Could someone review this?

@ikesyo ikesyo requested a review from das March 20, 2018 14:49
@ikesyo
Copy link
Member Author

ikesyo commented Mar 27, 2018

I’m gonna merge this after rebasing.

@ikesyo ikesyo removed the request for review from das March 27, 2018 13:52
…iate

The initializers used here are not optional ones, so there is no need to use `flatMap`.
@ikesyo ikesyo force-pushed the optional-map-over-flatmap branch from e830bec to 1c3909e Compare March 27, 2018 14:22
@ikesyo
Copy link
Member Author

ikesyo commented Mar 27, 2018

@swift-ci Please smoke test and merge

1 similar comment
@ikesyo
Copy link
Member Author

ikesyo commented Mar 27, 2018

@swift-ci Please smoke test and merge

@swift-ci swift-ci merged commit 01a9f61 into swiftlang:master Mar 27, 2018
@ikesyo ikesyo deleted the optional-map-over-flatmap branch March 27, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants