Skip to content

[+0-all-args] Be explicit about the module-name for tests that have p… #15165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

…lus_zero_* counterparts.

Otherwise, the plus_zero_* tests will have plus_zero_* as a module name, causing
massive FileCheck problems.

The reason why I am doing it with the main tests is so that I can use it when
syncing branches/etc.

rdar://34222540

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test and merge

@gottesmm gottesmm force-pushed the pr-f2900d946f9ba56e68c3c5431d6341f688321e30 branch from 463ecf6 to 9491f39 Compare March 11, 2018 22:27
@gottesmm
Copy link
Contributor Author

To make doing some other merging easier, I need to do a little cleanup commit first.

@gottesmm gottesmm force-pushed the pr-f2900d946f9ba56e68c3c5431d6341f688321e30 branch 2 times, most recently from c7512e0 to b3ae95f Compare March 11, 2018 23:23
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test and merge

5 similar comments
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test and merge

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test and merge

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test and merge

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test and merge

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test and merge

…lus_zero_* counterparts.

Otherwise, the plus_zero_* tests will have plus_zero_* as a module name, causing
massive FileCheck problems.

The reason why I am doing it with the main tests is so that I can use it when
syncing branches/etc.

radar://34222540
@gottesmm gottesmm force-pushed the pr-f2900d946f9ba56e68c3c5431d6341f688321e30 branch from b3ae95f to 6f4e87a Compare March 12, 2018 04:55
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test and merge

1 similar comment
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit fbab421 into swiftlang:master Mar 12, 2018
@gottesmm gottesmm deleted the pr-f2900d946f9ba56e68c3c5431d6341f688321e30 branch March 12, 2018 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants