Skip to content

[gardening][lib/Basic][C++11] Replace typedef with using #15169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2018
Merged

[gardening][lib/Basic][C++11] Replace typedef with using #15169

merged 1 commit into from
Mar 13, 2018

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Mar 12, 2018 •
edited
Loading

This is a series of pull requests attempting to replace typedefs with usings.

ikesyo
ikesyo commented Mar 12, 2018
View reviewed changes
lib/AST/ASTContext.cpp Outdated
typedef std::pair<DeclContext *, AbstractFunctionDecl *>
ObjCUnsatisfiedOptReq;
/// An unsatisfied, optional @objc requirement in a protocol conformance.
using ObjCUnsatisfiedOptReq = std::pair<DeclContext *, AbstractFunctionDecl *>;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation changes are due to git clang-format.

@ikesyo
Copy link
Member Author

ikesyo commented Mar 12, 2018

@swift-ci smoke test

@ikesyo ikesyo changed the title [gardening] Replace typedef with using [gardening][C++11] Replace typedef with using Mar 12, 2018
@DougGregor
Copy link
Member

I guess using is often cleaner, but... what's the heuristic you're using to decide which typedefs to change?

@ikesyo
Copy link
Member Author

ikesyo commented Mar 12, 2018 •
edited
Loading

I intend to replace most typedefs in subsequent PRs so there is no specific reasons for what I replaced in this PR. This is just a small start.

@ikesyo ikesyo force-pushed the using-over-typedef branch from 5879781 to 958c5ea Compare March 13, 2018 04:44
@ikesyo ikesyo changed the title [gardening][C++11] Replace typedef with using [gardening][lib/Basic][C++11] Replace typedef with using Mar 13, 2018
@ikesyo
Copy link
Member Author

ikesyo commented Mar 13, 2018 •
edited
Loading

but... what's the heuristic you're using to decide which typedefs to change?

Just narrowed the scope to only lib/Basic now.

@ikesyo ikesyo force-pushed the using-over-typedef branch from 958c5ea to eaf33e0 Compare March 13, 2018 04:46
@ikesyo
Copy link
Member Author

ikesyo commented Mar 13, 2018

@swift-ci smoke test

@DougGregor
Copy link
Member

Okay, thanks!

@DougGregor DougGregor merged commit a191b9e into swiftlang:master Mar 13, 2018
@ikesyo ikesyo deleted the using-over-typedef branch March 13, 2018 23:11
@ikesyo ikesyo mentioned this pull request Mar 14, 2018
Merged
This was referenced Mar 24, 2018
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 2, 2018
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikesyo @DougGregor