Skip to content

[silgen] Change SwitchEnumBuilder to invalidate the insertion point u… #15175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

…nconditonally after emitting a block, rather than asserting so.

If we perform an exit and do not use a terminator, then we will still have a set
insertion point. By unconditionally unsetting it, we gain the property that we
want and are nice to the normal exit case.

…nconditonally after emitting a block, rather than asserting so.

If we perform an exit and do not use a terminator, then we will still have a set
insertion point. By unconditionally unsetting it, we gain the property that we
want and are nice to the normal exit case.
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test and merge

@gottesmm
Copy link
Contributor Author

Same with this one.

@gottesmm gottesmm closed this Mar 12, 2018
@swift-ci swift-ci merged commit 1feaec3 into swiftlang:master Mar 12, 2018
@gottesmm gottesmm deleted the pr-a06a9d884e5fe4a32754f5918f5e8f51abcc5b9c branch March 12, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants