Skip to content

IRGen: Clean up FIXME in emitConditionalConformancesBuffer() #15200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2018
Merged

IRGen: Clean up FIXME in emitConditionalConformancesBuffer() #15200

merged 1 commit into from
Mar 13, 2018

Conversation

slavapestov
Copy link
Contributor

No description provided.

@slavapestov slavapestov requested a review from huonw March 13, 2018 08:29
@slavapestov
Copy link
Contributor Author

@huonw Something I noticed while working on protocol resilience. Does this make sense?

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov slavapestov force-pushed the conditional-buffer-cleanup branch from e37ed05 to 10eb178 Compare March 13, 2018 08:35
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

1 similar comment
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov slavapestov merged commit 5795bdf into swiftlang:master Mar 13, 2018
@huonw
Copy link
Contributor

huonw commented Mar 13, 2018

Nice! That parameter wasn't great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huonw huonw Awaiting requested review from huonw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slavapestov @huonw