IRGen: Make resilient enum's tag indices resilient #15208
Conversation
|
@swift-ci Please test |
|
Please add a test to validation-test/Evolution that shows this working at run time! :-) |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please test |
|
Build failed |
This allows reordering enum cases resiliently. rdar://24057946
aschwaighofer
force-pushed
the
resilient_enum_case_tags
branch
from
dc43d78 to
9d8c381
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
Hmm, after the rebase everything fails ... must have introduced new code since ... |
| @@ -6107,6 +6105,15 @@ void IRGenModule::emitEnumDecl(EnumDecl *theEnum) { | |||
| } | |||
|
|
|||
| emitFieldMetadataRecord(theEnum); | |||
|
|
|||
| if (isResilient(theEnum, ResilienceExpansion::Maximal)) | |||
There was a problem hiding this comment.
Don't you want to return if its not resilient?
There was a problem hiding this comment.
The code below emits the global variables for resilient enum tags. I only want to proceed to this code if we are within the same resilience domain not outside.
There was a problem hiding this comment.
When are we ever resilient here? Isn’t this the code for emitting an enum definition_? How can you define an enum that’s resilient to yourself?
There was a problem hiding this comment.
Good point. Rethinking that logic should we test if the enum is resilient and only then emit the globals (like you initially suggested)? Assuming, the transition from non-resilient to resilient is not allowed.
There was a problem hiding this comment.
Like so: #15401
|
Can you file a bug to have me or Huon update TBDGen as well? Or you can do it, it's trivial. You just have to emit the link entities when visiting an EnumDecl, and add a test case. |
|
I can take a look |
|
Please test |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please test source compatibility |
|
Successful source compatibility run is here: https://ci.swift.org/view/Pull%20Request/job/swift-PR-source-compat-suite/914/console |
This allows reordering enum cases resiliently.
rdar://24057946