[SwiftSyntax] Add SyntaxRewriter.visitAny(_:) #15212
Conversation
|
@swift-ci please smoke test |
|
hmm, this will make |
|
Ah, yes you're right - this would make it so Something like |
|
sounds good! |
harlanhaskins
force-pushed
the
open-sesame
branch
2 times, most recently
from
09db2e5 to
e8b0bdb
Compare
|
@swift-ci please smoke test |
|
|
||
| // Visit this node using the global visitor first | ||
| let newNode = visitAny(node) | ||
| switch newNode.raw.kind { |
There was a problem hiding this comment.
this two-phase transformation may complicate clients' codebase. Can we force users to choose either using visitAny or visit(_ node: SpecializedSyntax)? meaning if visitAny changed a node, we don't call visit(_ node: SpecializedSyntax) any more.
There was a problem hiding this comment.
That makes sense, I'll do that!
harlanhaskins
force-pushed
the
open-sesame
branch
2 times, most recently
from
dccecde to
91a27ea
Compare
| // If the global visitor returned non-nil, visit the rewritten node's | ||
| // children and skip specialized dispatch. | ||
| if let newNode = visitAny(node) { | ||
| return visitChildren(newNode) |
There was a problem hiding this comment.
hmm, sorry about being a little nit-picky here. Whether visitingChildren should be up to the overriding function, right? like other specialized visit functions.
There was a problem hiding this comment.
Oh, yes you're right. Thanks for catching that!
There was a problem hiding this comment.
The more I think about it, though, the more I wonder if we should always call visitChildren after the specialized visitor has been called.
For example, if I'm writing a transform that, say, lays out function call arguments a certain way, I shouldn't have to manually iterate over all subexpressions and visit them, no?
There was a problem hiding this comment.
yeah, i think it is a valid assumption that in most cases users will visit a node's children even though the node itself has been updated. @rintaro what do you think?
There was a problem hiding this comment.
Perhaps, we should separate Visitor and Walker like ASTVisitor / ASTWalker.
harlanhaskins
force-pushed
the
open-sesame
branch
from
91a27ea to
1dcf5f4
Compare
harlanhaskins
changed the title
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test |
harlanhaskins
force-pushed
the
open-sesame
branch
from
42d96ae to
48ce47f
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
* [SwiftSyntax] Add SyntaxRewriter.visitAny(_:) This function, when overridden, allows Syntax rewriters to perform custom dynamic visitation behavior. If a user wanted to, say, store a series of transformations accessible by metatype, they can override visitAny and do their own runtime dispatch. If a non-nil result is returned from visitAny, the original specialized visitors are skipped.
This patch makes it so clients can override
visit(_ node: Syntax) -> SyntaxinSyntaxRewriterandSyntaxVisitorsubclasses, if they choose to override the global visitation behavior.