-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[build-script] Stop forcing the use of libcxx #15233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build-script] Stop forcing the use of libcxx #15233
Conversation
Let's do a full test to see if anything has a lingering dependency on libcxx being explicit. @swift-ci please test |
Build failed |
Looks unrelated. Actually, those are timeouts from turning on resilience, whoops. (@slavapestov) |
Thanks @jrose-apple for checking. Given that you asked me to run this topic by the forums, how long do you want to wait for people to speak their mind about this topic? |
I'm not sure. Maybe till the end of the week? The other possibility would be to tag specific people on the forums who work on non-Apple platforms, like the IBM folks, and see if they have any specific concerns. But it's always something we can roll back if it causes problems. (We really need that secondary buildbot suite…) |
Until the end of the week sounds fine. Somebody who works on Windows has already said via GitHub that the MS C++ standard library works fine, so now we're up three known working libraries. If it were up to me, and given that the cost of reverting this is super low, I'd just merge this PR at this point. |
Also, I don't know who the IBM folks are. |
@swift-ci please smoke test osx |
I can't reproduce the two timeouts locally (though admittedly with my own preset, not the builder's). Maybe a clean test'll clear it up? @swift-ci Please clean smoke test macOS |
@swift-ci Please clean smoke test OS X |
@swift-ci please clean smoke test OS X |
Any C++ standard library is good enough these days.
2fca15f
to
b6c3021
Compare
Maybe something is out of sync on the macOS side. I'm rebasing and trying again. @swift-ci please smoke test |
The PowerPC and S390 folks at IBM signed off on this via the forums. I'm going to merge this now. We can always revert this. |
Any C++ standard library is good enough these days.