Skip to content

[build-script] Stop forcing the use of libcxx #15233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2018

Conversation

davezarzycki
Copy link
Contributor

Any C++ standard library is good enough these days.

@davezarzycki
Copy link
Contributor Author

Let's do a full test to see if anything has a lingering dependency on libcxx being explicit.

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 2fca15f638d8edd0c307b7b4b42a0977c0e52667

@jrose-apple
Copy link
Contributor

Looks unrelated. Actually, those are timeouts from turning on resilience, whoops. (@slavapestov)

@davezarzycki
Copy link
Contributor Author

Thanks @jrose-apple for checking. Given that you asked me to run this topic by the forums, how long do you want to wait for people to speak their mind about this topic?

@jrose-apple
Copy link
Contributor

I'm not sure. Maybe till the end of the week? The other possibility would be to tag specific people on the forums who work on non-Apple platforms, like the IBM folks, and see if they have any specific concerns. But it's always something we can roll back if it causes problems.

(We really need that secondary buildbot suite…)

@davezarzycki
Copy link
Contributor Author

Until the end of the week sounds fine. Somebody who works on Windows has already said via GitHub that the MS C++ standard library works fine, so now we're up three known working libraries. If it were up to me, and given that the cost of reverting this is super low, I'd just merge this PR at this point.

@davezarzycki
Copy link
Contributor Author

Also, I don't know who the IBM folks are.

@davezarzycki
Copy link
Contributor Author

@swift-ci please smoke test osx

@jrose-apple
Copy link
Contributor

I can't reproduce the two timeouts locally (though admittedly with my own preset, not the builder's). Maybe a clean test'll clear it up?

@swift-ci Please clean smoke test macOS

@jrose-apple
Copy link
Contributor

@swift-ci Please clean smoke test OS X

@davezarzycki
Copy link
Contributor Author

@swift-ci please clean smoke test OS X

Any C++ standard library is good enough these days.
@davezarzycki davezarzycki force-pushed the stop_forcing_libcxx_use branch from 2fca15f to b6c3021 Compare March 14, 2018 22:04
@davezarzycki
Copy link
Contributor Author

Maybe something is out of sync on the macOS side. I'm rebasing and trying again.

@swift-ci please smoke test

@davezarzycki
Copy link
Contributor Author

The PowerPC and S390 folks at IBM signed off on this via the forums. I'm going to merge this now. We can always revert this.

@davezarzycki davezarzycki merged commit 900c01f into swiftlang:master Mar 16, 2018
@davezarzycki davezarzycki deleted the stop_forcing_libcxx_use branch March 16, 2018 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants