SR-2100 - Add support for multi-lib systems #15260
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Creating build variable for proper suffixing of lib as lib64 as required for proper multilib
…tead of automake.
can select it with the build modifier --libdir-suffix when using the build-script from swift source tree. So, with a --libdir-suffix=64, everything will be compiled to work and install files on /usr/lib64 for example. Ommiting it should default to a plain lib, without a suffix.
Fix for lib suffix for linux
Fix change on build-script-impl for lib(suffix) with upstream
…ead of LIBDIR env variable
ghost
mentioned this pull request
|
I will close this pull request for now. Too much work on the other repositories that this change depends on before it could be integrated that need to be accepted first. Just leaving this lingering on open is increasing the number of file conflicts, making the merge difficult. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SR-2100 - Add support for multi-lib systems
Creates a new --libdir-suffix option to set a suffix for the library directory, so Linux
systems that uses "lib64" for 64-bit libraries (like Fedora) could package Swift without
the need for patches.
This option works by setting a new LIBDIR variable, use on all invocations of the
build-script, and passing down the option to subprojects as needed.
When no suffix is defined, uses the "lib" folder as currently it does under Ubuntu systems
For this to work properly when compiling a full swift distribution, the pull requests of
the other projects must be accepted, otherwise, the build will fail.