IDE: Don't crash in type reconstruction if local types contain subscripts #15285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipt or deinit This is just a workaround to unblock something else I'm doing. We're still not able to find the local declarations properly.
|
@dcci Hey we were feeding special DeclNames to unqualified lookup, which triggers an assert. This patch just dodges the assert without fixing the lookup at all. I hope it doesn't cause any major merge conflicts for your work, you can just revert it once you redo this code path. I need it to unblock #15201. |
|
@swift-ci Please smoke test |
|
@slavapestov no, this is fine, thanks for taking care of this. I'll revert once we have a better story for type reconstruction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a workaround to unblock something else I'm doing.
We're still not able to find the local declarations properly.