Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSB
commented
Mar 16, 2018
| @@ -126,8 +126,8 @@ set llvm_bin_dir="%swift_source_dir%/build/Ninja-DebugAssert/llvm-windows-amd64/ | |||
| - You may need to adjust the `SWIFT_WINDOWS_LIB_DIRECTORY` parameter depending on | |||
| your target platform or Windows SDK version. | |||
| ```cmd | |||
| mkdir "%swift_source_dir%/build/Ninja-DebugAssert/swift-windows-amd64/ninja" | |||
| pushd "%swift_source_dir%/build/Ninja-DebugAssert/swift-windows-amd64/ninja" | |||
There was a problem hiding this comment.
@compnerd I can't remember if one needs to cd into the ninja dir to run cmake. Is pushding into the parent ok?
If you're not sure I'll probably run this Monday/Tuesday next week and we can test then
There was a problem hiding this comment.
Id say test, but you can pass the path to the cmake invocation.
There was a problem hiding this comment.
I'll test on the next time I do a clean build
|
@swift-ci please smoke test |
|
@RUSshy: a nightly build of what? Swift compiled for native windows? I don't think so, but you can build it yourself! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.