Cleanup tgmath wrappers. #15304
Merged
Cleanup tgmath wrappers. #15304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stephentyrone
commented
Mar 16, 2018
stephentyrone
commented
- Remove special-case gyb logic for lgamma on Darwin; the symbols we need are always present, even if not visible in the headers, so we only need a prototype.
- Add some deprecations for symbols that have direct stdlib analogues.
- Make some operations generic on [Binary]FloatingPoint, where they can map to the protocols instead of calling libm.
- Remove special-case gyb logic for lgamma on Darwin; the symbols we need are always present, even if not visible in the headers, so we only need a prototype. - Add some deprecations for symbols that have direct stdlib analogues. - Make some operations generic on [Binary]FloatingPoint, where they can map to the protocols instead of calling libm.
moiseev
approved these changes
Mar 16, 2018
| return (x.significand / 2, Int(x.exponent + 1)) | ||
| } | ||
|
|
||
| @available(swift, deprecated: 4.2, message: "Use scalbn<T>(:T,:Int).") |
There was a problem hiding this comment.
Does scalbn give the same result? If so, then maybe a renamed: instead of message: would provide a better developer experience (i.e. fix-it and migration).
UPD: It does look like the implementation for scalbn is similar.
There was a problem hiding this comment.
Yeah, they're identical in actual behavior for every current type. They would behave differently for decimal types, but we don't really want these to be the interfaces going forward anyway.
|
@swift-ci Please Test Source Compatibility |
|
@swift-ci please test |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please smoke test OS X. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.