[CMake] Unbreak unified builds #15318
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are starting to fail if SWIFT_STDLIB_ENABLE_RESILIENCE does not default to true (the build-script sets this to true by default).
|
@swift-ci please smoke test and merge |
|
You might be the only one who uses unified builds -- why don't you use build-script? |
|
Also I'm removing this flag in #15319 |
|
For various reasons, I've never liked the build-script and it seems like a shame that the out-of-the-box CMake files work 99.9% of the time. The build-script is slow and a needless over-abstraction that also imposes a workflow / filesystem layout that isn't for everyone. |
|
In any case this is no longer needed once my other change goes in because SWIFT_STDLIB_ENABLE_RESILIENCE is not used anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are starting to fail if SWIFT_STDLIB_ENABLE_RESILIENCE does not default to true (the build-script sets this to true by default). For example, see the discussion in #15248.