Skip to content

[gardening][Data] Prefer !isEmpty over count > 0 #15326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2018
Merged

[gardening][Data] Prefer !isEmpty over count > 0 #15326

merged 1 commit into from
Mar 21, 2018

Conversation

ikesyo
Copy link
Member

@ikesyo ikesyo commented Mar 17, 2018

No description provided.

@ikesyo
Copy link
Member Author

ikesyo commented Mar 17, 2018

@swift-ci Please smoke test

@ikesyo ikesyo mentioned this pull request Mar 20, 2018
Merged
@ikesyo
Copy link
Member Author

ikesyo commented Mar 20, 2018

Ref: #15335

@jrose-apple jrose-apple requested a review from phausler March 20, 2018 02:35
phausler
phausler approved these changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@phausler phausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me - ought to be isomorphic

@ikesyo
Copy link
Member Author

ikesyo commented Mar 21, 2018

Thanks @phausler!

@ikesyo ikesyo merged commit c133e09 into swiftlang:master Mar 21, 2018
@ikesyo ikesyo deleted the use-isempty-over-count branch March 21, 2018 00:54
@ikesyo ikesyo mentioned this pull request Mar 22, 2018
Merged
@ikesyo ikesyo mentioned this pull request Apr 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phausler phausler phausler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikesyo @phausler