[SourceKit] Fix compiler warning. #15332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use const_cast instead of C style cast.
CodaFi
reviewed
Mar 19, 2018
| @@ -247,7 +247,7 @@ void ResponseBuilder::Dictionary::setCustomBuffer( | |||
| std::unique_ptr<llvm::MemoryBuffer> CustomBuf; | |||
| CustomBuf = llvm::WritableMemoryBuffer::getNewUninitMemBuffer( | |||
| sizeof(uint64_t) + MemBuf->getBufferSize()); | |||
| char *BufPtr = (char*)CustomBuf->getBufferStart(); | |||
| char *BufPtr = const_cast<char*>(CustomBuf->getBufferStart()); | |||
There was a problem hiding this comment.
I think the real problem is that the unique_ptr owns a llvm::MemoryBuffer instead of a llvm::WritableMemoryBuffer (which does the const_cast for you, the evil thing).
Based on PR feedback from @CodaFi
|
Good call @CodaFi Updated accordingly. |
|
Thanks @swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use const_cast instead of C style cast.
Simple warning fix. Use const cast instead of C-style cast to prevent warning of removing const qualifier. (I am using this trivial PR to get practice.
No SR for this one AFAIK.