Merge getRuntimeLibraryPath and getRuntimeStaticLibraryPath #15388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@compnerd smoke test and merge please |
compnerd
requested changes
Mar 21, 2018
lib/Driver/ToolChains.cpp
Outdated
| llvm::sys::path::append(runtimeLibPath, "lib", "swift"); | ||
| } else { | ||
| llvm::sys::path::append(runtimeLibPath, "lib", "swift_static"); | ||
| } |
There was a problem hiding this comment.
I think this is better as a ternary:
llvm::sys::path::append(runtimeLibpath, "lib", shared ? "swift" : "swift_static");
lib/Driver/ToolChains.cpp
Outdated
| @@ -1047,43 +1052,21 @@ static void getClangLibraryPath(const ToolChain &TC, const ArgList &Args, | |||
| SmallString<128> &LibPath) { | |||
| const llvm::Triple &T = TC.getTriple(); | |||
|
|
|||
| getRuntimeLibraryPath(LibPath, Args, TC); | |||
| getRuntimeLibraryPath(LibPath, Args, TC, true); | |||
There was a problem hiding this comment.
Please add a comment:
getRuntimeLibraryPath(LibPath, Args, TC, /*Shared=*/true);
Similar throughout.
There was a problem hiding this comment.
Gross, if only there was a language with functions with named arguments.
These two functions are duplicates except for one string. Merge them and add an argument for whether we want static or shared.
compnerd
approved these changes
Mar 22, 2018
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two functions are duplicates except for one string. Merge them and
add an argument for whether we want static or shared.