Skip to content

[RemoteMirrors] Interop header fixes and library lookup caching. #15395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 21, 2018
Merged

[RemoteMirrors] Interop header fixes and library lookup caching. #15395

merged 7 commits into from
Mar 21, 2018

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Mar 21, 2018

Some deficiencies in the interop API were identified when an actual client started trying to use it.

  • typeinfo and childinfo needed interop variants that used interop variants for their fields.
  • The client needed to be able to look things up starting from a metadata address directly, rather than starting from an object.
  • Figuring out which library owns a particular metadata address is not particularly fast, but is done frequently, so it needed a cache.

rdar://problem/37538580

mikeash added 7 commits March 8, 2018 10:28
@mikeash
Copy link
Contributor Author

mikeash commented Mar 21, 2018

@swift-ci please test

@mikeash mikeash merged commit ce0ef07 into swiftlang:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikeash