[4.2] IRGen: Fix witness-table accessors for conditional conformances #15423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick of swiftlang#15397. The conditional conformance's witness table accessor function takes as arugment an array of conditional conformances in memory. But we used to mark the accessor function with LLVM's readnone attribute. In optimized mode this would cause the store to this array to be removed and crashes ensued. rdar://38624842 SR-7228
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #15397.
The conditional conformance's witness table accessor function takes as
arugment an array of conditional conformances in memory. But we used to
mark the accessor function with LLVM's readnone attribute. In optimized
mode this would cause the store to this array to be removed and crashes
ensued.
rdar://38624842
SR-7228