Skip to content

Add a --no-test option to build-toolchain #15424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aschwaighofer
Copy link
Contributor

Builds a toolchain without running tests on macos.

Builds a toolchain without running tests on macos.
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please smoke test and merge

@jrose-apple
Copy link
Contributor

jrose-apple commented Mar 22, 2018

Is this better than just changing the default? @shahmishal, @Rostepher, @zisko

@aschwaighofer
Copy link
Contributor Author

Changing the default will need to be synchronized with the bot setups and needs to be done by folks in charge of those. This is better than not having the option at all.

I agree with you otherwise that we could just do what we do on linux: change the default and use the --test option.

@swift-ci swift-ci merged commit 8e6291f into swiftlang:master Mar 22, 2018
@shahmishal
Copy link
Member

‘build-toolchain’ is not used in CI, however people in the community might be using it to build toolchain for other platform.

@aschwaighofer
Copy link
Contributor Author

@shahmishal On linux the default is to build the toolchain in the no_test preset. Only on macOS we build the preset that tests. On linux you have to add --test if you want the preset with tests.

I can change the behavior on macOS to mirror what we do on linux if that won't break CI (as you suggest) and folks are okay with that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants