[lldb-moduleimport-test] Refactor dump of types from mangled name. #15425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for adding dump decl from mangled name.
dcci
requested review from
slavapestov,
adrian-prantl,
jrose-apple and
fredriss
|
@swift-ci please smoke test and merge |
jrose-apple
reviewed
Mar 22, 2018
| @@ -62,6 +62,33 @@ static void printValidationInfo(llvm::StringRef data) { | |||
| } | |||
| } | |||
|
|
|||
| static void resolveTypeFromMangledNameList( | |||
| swift::ASTContext &Ctx, llvm::SmallVector<std::string, 8> &MangledNames) { | |||
There was a problem hiding this comment.
LLVM style nitpicks: ArrayRef here…
|
|
||
| static void | ||
| collectMangledNames(std::string &FilePath, | ||
| llvm::SmallVector<std::string, 8> &MangledNames) { |
There was a problem hiding this comment.
…and SmallVectorImpl here (don't need to hardcode the size). Also, const on FilePath.
|
Thanks for your review Jordan, I'll include these fixes in my next pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for adding support for dump decl from mangled name.