[Sema] NFC: Ensure that Decls have one-way validation state #15427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also tried to move the early attribute validation bit into this enum, but as it turns out, decls aren't consistent about when they do early attribute checking relative to calling setIsBeingValidated(). Some do early attribute checking before validation, others do it after, and some do it during. I tried to make early attribute checking be consistently early, but that broke a few tests.
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also tried to move the early attribute validation bit into this enum, but as it turns out, decls aren't consistent about when they do early attribute checking relative to calling
setIsBeingValidated(). Some do early attribute checking before validation, others do it after, and some do it during. I tried to make early attribute checking be consistently early, but that broke a few tests.