Make the naming of underlying builtin for FP + Vector match Integer. #15430
Conversation
For stdlib integer types, these builtin wrapped by the Swift type is named _value and the init is (_ _value: Builtin.xxx). This patch adopts the same scheme for stdlib floating point and SDK overlay vector types, and removes a legacy init for integers that was only needed to support them. There should be no changes visible outside of the stdlib.
|
@swift-ci Please smoke test. |
|
@stephentyrone I'm going to revert this because it broke the source compat suite (not your fault, it's a constraint solver bug). However what exposed the bug is the addition of new unlabeled initializers on numeric types. I think we want to avoid these because they make the type checker go exponential. Since builtin types are never public, we can change these initializers without breaking anyone. Do you want to give them labels again on floats and integers? |
…nteger. (swiftlang#15430)" This reverts commit 8e11af4.
|
As long as the initializers are not failable I don't think they're going to cause any problems. If all the overloads in an overload set return the same type we're able to split the constraint system which avoids the exponential behavior. The problem we have with Int, Float, etc. is that around Swift 3.1 (?) timeframe we introduced unlabeled failable inits. |
For stdlib integer types, these are named
_valueandinit(_ _value: Builtin.xxx). This patch adopts the same scheme for stdlib floating point and SDK overlay vector types, and removes a legacy init for integers that was only needed to support them. There should be no changes visible outside of the stdlib, and no functional change within the stdlib; the naming of some implementation details is simply more uniform now.