[lldb-moduleimport] Add the logic for testing getDeclBySymbolName(). #15431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 22, 2018 10:07
Adrian already found and reported a bug, which I'm going to fix in a later commit. Eventually this will go away, but in the meanwhile, we should add test for this codepath. <rdar://problem/38720742>
dcci
requested review from
slavapestov,
adrian-prantl,
jrose-apple and
fredriss
|
@swift-ci please smoke test and merge |
|
It looks like this is preventing any pull requests from getting through because the test fails on i386. Could you disable it for 32 bits until a proper fix is available? |
|
#15432 should take care of this. |
|
(and sorry) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adrian already found and reported a bug, which I'm going to fix
in a later commit. Eventually this will go away, but in the meanwhile,
we should add test for this codepath.
rdar://problem/38720742
(I also decided to sneak in another commit to address Jordan's post commit reviews).