[local] Change some for-loops in analyzeStaticInitializer to use llvm…

[gottesmm]

…::none_of.

Noticed this while trying to understand the code in global opt that uses this. I
also did a little style cleanup in the function.

NFC.

[gottesmm]

@swift-ci smoke test and merge

[gottesmm]

@swift-ci smoke test and merge

[davezarzycki]

Is it possible to avoid the negation via llvm::all_of? For example, this reads better:

return llvm::all_of(SI->getAllOperands(), [&](Operand &Op) -> bool {
  return analyzeStaticInitializer(Op.get(), Insts);
});

[gottesmm]

@davezarzycki Sure. I will do it in a follow up.

[gottesmm]

@davezarzycki #15515