[SR-6907] Add appropriate bounds to CountableClosedRange and CountableRange. #15513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only the last commit is relative to this PR; the rest are part of #15497. |
|
@swift-ci please test source compatibility |
|
Expecting a UPASS in the source compatibility suite for GRDB; everything else should be unchanged. |
DougGregor
changed the title
Previously, both CountableRange and CountableClosedRange required their bound types to be Strideable with a Stride type that conforms to SignedInteger. Those constraints were not present on the generic typealiases that replaced these structs. Add them back now, which fixes the GRDB source compatibility regression. Fixes https://bugs.swift.org/browse/SR-6907 / rdar://problem/29066394.
DougGregor
force-pushed
the
range-typealias-bounds-sr-6907
branch
from
2e9a021 to
e0d423a
Compare
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Swift 4.1 and earlier, both
CountableRangeandCountableClosedRangerequiredtheir bound types to be
Strideablewith aStridetype that conforms toSignedInteger. Those constraints were not present on the generictypealiases that replaced these structs. Add them back now, which
fixes the GRDB source compatibility regression.
Fixes SR-6907 / rdar://problem/29066394.