[AST] Skip verification of typealiases marked as "debugger aliases". #15527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLDB creates global typealiases that have archetypes in them, which violates AST invariants and trips up the AST verifier. Introduce a specific bit that LLDB can set to indicate that a given typealias is such an alias. We'll skip AST verification for such typealiases. As a way to stage in this change without requiring synchronization across the Swift and LLDB repos, also match typealiases with the names $.*lldb in the AST verifier and skip verification. Once LLDB is setting the bit appropriately, we'll remove this hack.
|
@swift-ci please smoke test |
DougGregor
referenced
this pull request
Mar 27, 2018
Something in the interface between LLDB and Swift is causing this check to fire. Disable it temporarily while we work on that interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLDB creates global typealiases that have archetypes in them, which
violates AST invariants and trips up the AST verifier. Introduce a specific
bit that LLDB can set to indicate that a given typealias is such an alias.
We'll skip AST verification for such typealiases.
As a way to stage in this change without requiring synchronization
across the Swift and LLDB repos, also match typealiases with the names
$.*lldb in the AST verifier and skip verification. Once LLDB is
setting the bit appropriately, we'll remove this hack.