Skip to content

[Sema] NFC: Use exhaustive switches in PatternKind::Named #15540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

davezarzycki
Copy link
Contributor

Also, flip the polarity so that programmers that add new ReferenceOwnership kinds know what to do. This is a followup to #15419.

@davezarzycki davezarzycki requested a review from rudkx March 27, 2018 14:30
@davezarzycki
Copy link
Contributor Author

@swift-ci please smoke test

Also, flip the polarity so that programmers that add new
ReferenceOwnership kinds know what to do.
@davezarzycki davezarzycki force-pushed the nfc_flip_named_patternkind_polarity branch from 20c31aa to 62b5dc1 Compare March 27, 2018 15:08
@davezarzycki
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Contributor

@rudkx rudkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@davezarzycki
Copy link
Contributor Author

Thanks @rudkx – This makes my research branch easier to maintain.

@davezarzycki davezarzycki deleted the nfc_flip_named_patternkind_polarity branch March 27, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants