SILGenPattern cleanup #15554
Merged
SILGenPattern cleanup #15554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
No functionality change.
This used to model the difference between Optional.some and IUO.some, but that's gone now! No functionality change.
jrose-apple
force-pushed
the
SILGenPattern-cleanup
branch
from
7db93aa to
7987cdc
Compare
|
@swift-ci Please smoke test |
|
Okay, maybe I didn't need this cleanup, but it's still a good cleanup. |
|
@swift-ci Please smoke test Linux |
slavapestov
approved these changes
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two simple cleanups for the parts of SILGenPattern I modified in #14724:
No functionality change, but makes my next task easier: emitting a good diagnostic when an unknown case value does end up unhandled in a switch (rdar://problem/37728359). Right now it just traps.