Fix various bogus unreachable code warnings #15567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@jckarter what's the difference between CleanupLocation and calling SILLocation::markAutoGenerated()? |
jckarter
reviewed
Mar 28, 2018
lib/SIL/SILType.cpp
Outdated
| @@ -638,17 +638,17 @@ bool SILModuleConventions::isPassedIndirectlyInSIL(SILType type, SILModule &M) { | |||
| } | |||
|
|
|||
| bool SILFunctionType::isNoReturnFunction() { | |||
| return getDirectFormalResultsType().getSwiftRValueType()->isUninhabited(); | |||
| if (getNumResults() == 1) | |||
| return getSingleResult().getType()->isUninhabited(); | |||
There was a problem hiding this comment.
A function would be noreturn if any of its results are uninhabited, wouldn't it?
|
AIUI both have the same ultimate effect of being treated as implicit by the debugger. |
slavapestov
force-pushed
the
never-fixes
branch
4 times, most recently
from
21ea0c2 to
5e4b2c5
Compare
…n in witness thunks
… that return Never indirectly
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
1 similar comment
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
1 similar comment
|
@swift-ci Please test source compatibility |
|
Source compat failure is some watchOS availability thing unrelated to my changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the re-opened https://bugs.swift.org/browse/SR-2729. Also might fix https://bugs.swift.org/browse/SR-3696 but I don't have a Linux machine available right now.