Skip to content

[stdlib] Set, Dictionary: Clarify assert message when a duplicate key is found #15569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2018
Merged

[stdlib] Set, Dictionary: Clarify assert message when a duplicate key is found #15569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stdlib/public/core/Dictionary.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2538,8 +2538,8 @@ extension _NativeDictionaryBuffer where Key: Hashable
@_versioned // FIXME(sil-serialize-all)
internal func unsafeAddNew(key newKey: Key, value: Value) {
let (i, found) = _find(newKey, startBucket: _bucket(newKey))
_sanityCheck(
!found, "unsafeAddNew was called, but the key is already present")
_precondition(
!found, "Duplicate key found in Dictionary. Keys may have been mutated after insertion")
initializeKey(newKey, value: value, at: i.offset)
}

Expand Down
4 changes: 2 additions & 2 deletions stdlib/public/core/Set.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2161,8 +2161,8 @@ extension _NativeSetBuffer where Element: Hashable
@_versioned // FIXME(sil-serialize-all)
internal func unsafeAddNew(key newKey: Element) {
let (i, found) = _find(newKey, startBucket: _bucket(newKey))
_sanityCheck(
!found, "unsafeAddNew was called, but the key is already present")
_precondition(
!found, "Duplicate element found in Set. Elements may have been mutated after insertion")
initializeKey(newKey, at: i.offset)
}

Expand Down