Fix dependent protocol conformance records #15573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
dependent-conformance-records
branch
from
ab54912 to
9dba1ff
Compare
ghost
approved these changes
Mar 28, 2018
DougGregor
approved these changes
Mar 28, 2018
slavapestov
force-pushed
the
dependent-conformance-records
branch
2 times, most recently
from
1504963 to
6c9df59
Compare
…references for Error bridging This breaks with resilient conformances once the pattern symbol is no longer public.
…e the witness table accessor function ... and not the pattern, which is about to get non-public linkage.
Witness tables for conformances that require runtime instantiation should not be public, because it is an error to directly reference such a symbol from outside the module. Use a different mangling for witness table patterns and give them non-public linkage.
slavapestov
force-pushed
the
dependent-conformance-records
branch
from
6c9df59 to
30a3e75
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol conformance records for dependent conformances (ie, requiring instantiation) directly referenced the witness table pattern and not the accessor function. This is incorrect. To prevent the problem from happening again, give witness table patterns a different mangling with private linkage. Also, change the runtime use witness table accessors rather than direct references to witness tables in the Foundation module in a couple of spots. These conformances are resilient and also require instantiation.