[CSSolver] Remove tuple-to-tuple narrow perf hack

[xedin]

Don't try to short-circuit disjunctions if one of the choices
produced tuple-to-tuple conversion since that doesn't mean
that there are no other choices out there.

[xedin]

@swift-ci please test source compatibility

[xedin]

@swift-ci please smoke test compiler performance

[swift-ci]

Build comment file:

Summary for master smoketest

Unexpected test results, excluded stats for ReactiveCocoa

No regressions above thresholds

• Debug
  • debug brief
  • debug detailed
• Release
  • release brief
  • release detailed

Debug

debug brief

Regressed (0)

name	old	new	delta	delta_pct

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (2)

name	old	new	delta	delta_pct
LLVM.NumLLVMBytesOutput	40,796,478	40,798,065	1,587	0.0%
time.swift-driver.wall	69.8s	69.7s	-31.5ms	-0.05%

debug detailed

Regressed (0)

name	old	new	delta	delta_pct

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (23)

name	old	new	delta	delta_pct
AST.NumImportedExternalDefinitions	91,042	91,042	0	0.0%
AST.NumLoadedModules	12,830	12,830	0	0.0%
AST.NumTotalClangImportedEntities	272,218	272,218	0	0.0%
AST.NumUsedConformances	8,723	8,723	0	0.0%
IRModule.NumIRBasicBlocks	124,899	124,899	0	0.0%
IRModule.NumIRFunctions	72,398	72,398	0	0.0%
IRModule.NumIRGlobals	66,597	66,597	0	0.0%
IRModule.NumIRInsts	1,405,407	1,405,407	0	0.0%
IRModule.NumIRValueSymbols	123,403	123,403	0	0.0%
LLVM.NumLLVMBytesOutput	40,796,478	40,798,065	1,587	0.0%
SILModule.NumSILGenFunctions	46,832	46,832	0	0.0%
SILModule.NumSILOptFunctions	85,464	85,464	0	0.0%
Sema.NumConformancesDeserialized	442,227	442,227	0	0.0%
Sema.NumConstraintScopes	915,958	915,958	0	0.0%
Sema.NumDeclsDeserialized	2,764,017	2,764,017	0	0.0%
Sema.NumDeclsValidated	158,911	158,911	0	0.0%
Sema.NumFunctionsTypechecked	52,354	52,354	0	0.0%
Sema.NumGenericSignatureBuilders	66,596	66,596	0	0.0%
Sema.NumLazyGenericEnvironments	520,080	520,080	0	0.0%
Sema.NumLazyGenericEnvironmentsLoaded	43,556	43,556	0	0.0%
Sema.NumLazyIterableDeclContexts	368,605	368,605	0	0.0%
Sema.NumTypesDeserialized	2,960,743	2,960,743	0	0.0%
Sema.NumTypesValidated	241,142	241,142	0	0.0%

Release

release brief

Regressed (0)

name	old	new	delta	delta_pct

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (2)

name	old	new	delta	delta_pct
LLVM.NumLLVMBytesOutput	30,155,326	30,155,312	-14	-0.0%
time.swift-driver.wall	160.2s	160.6s	418.0ms	0.26%

release detailed

Regressed (0)

name	old	new	delta	delta_pct

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (23)

name	old	new	delta	delta_pct
AST.NumImportedExternalDefinitions	8,768	8,768	0	0.0%
AST.NumLoadedModules	400	400	0	0.0%
AST.NumTotalClangImportedEntities	25,361	25,361	0	0.0%
AST.NumUsedConformances	8,728	8,728	0	0.0%
IRModule.NumIRBasicBlocks	168,663	168,663	0	0.0%
IRModule.NumIRFunctions	55,753	55,753	0	0.0%
IRModule.NumIRGlobals	52,751	52,751	0	0.0%
IRModule.NumIRInsts	1,414,655	1,414,655	0	0.0%
IRModule.NumIRValueSymbols	97,856	97,856	0	0.0%
LLVM.NumLLVMBytesOutput	30,155,326	30,155,312	-14	-0.0%
SILModule.NumSILGenFunctions	22,985	22,985	0	0.0%
SILModule.NumSILOptFunctions	38,622	38,622	0	0.0%
Sema.NumConformancesDeserialized	137,844	137,844	0	0.0%
Sema.NumConstraintScopes	803,629	803,629	0	0.0%
Sema.NumDeclsDeserialized	225,355	225,355	0	0.0%
Sema.NumDeclsValidated	28,507	28,507	0	0.0%
Sema.NumFunctionsTypechecked	10,698	10,698	0	0.0%
Sema.NumGenericSignatureBuilders	6,391	6,391	0	0.0%
Sema.NumLazyGenericEnvironments	32,985	32,985	0	0.0%
Sema.NumLazyGenericEnvironmentsLoaded	4,508	4,508	0	0.0%
Sema.NumLazyIterableDeclContexts	21,029	21,029	0	0.0%
Sema.NumTypesDeserialized	274,991	274,991	0	0.0%
Sema.NumTypesValidated	40,333	40,333	0	0.0%

---

[xedin]

source compatibility failed because of ReactiveCocoa, going to re-run since it going XFAIL'ed.

[xedin]

@swift-ci please test source compatibility

[xedin]

@swift-ci please clean test

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - 641b80b

[xedin]

@swift-ci please test macOS platform