Implement SE-0193 - part 1 #15594
Implement SE-0193 - part 1 #15594
Conversation
|
@airspeedswift @milseman @lorentey @lancep Just a heads-up that I'm planning on landing this shortly, and it touches a lot of stdlib files. Do you have any big changes in flight I should wait for? |
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
Build failed |
|
@swift-ci Please test source compatibility |
include/swift/AST/Decl.h
Outdated
| @@ -2244,12 +2245,12 @@ class ValueDecl : public Decl { | |||
| /// | |||
| /// \sa getFormalAccessScope | |||
| AccessLevel getFormalAccess(const DeclContext *useDC = nullptr, | |||
| bool respectVersionedAttr = false) const { | |||
| bool respectUsableFromInline = false) const { | |||
There was a problem hiding this comment.
This flag no longer makes sense. Hm. Maybe an explicit "treatUsageFromInlineAsPublic"?
There was a problem hiding this comment.
isUsageFromInline? It’s kind of weird isn’t it
lib/AST/Decl.cpp
Outdated
| /// at the SIL, LLVM, and machine levels due to being versioned. | ||
| bool ValueDecl::isVersionedInternalDecl() const { | ||
| /// at the SIL, LLVM, and machine levels due to being @usableFromInline. | ||
| bool ValueDecl::isUsableFromInlineDecl() const { |
There was a problem hiding this comment.
Nitpick: This probably doesn't need Decl on the end anymore.
lib/Sema/TypeCheckAttr.cpp
Outdated
| @@ -84,7 +84,7 @@ class AttributeEarlyChecker : public AttributeVisitor<AttributeEarlyChecker> { | |||
| IGNORED_ATTR(ImplicitlyUnwrappedOptional) | |||
| IGNORED_ATTR(Infix) | |||
| IGNORED_ATTR(Inline) | |||
| IGNORED_ATTR(Inlineable) | |||
| IGNORED_ATTR(Inlinable) | |||
There was a problem hiding this comment.
This list is alphabetized.
There was a problem hiding this comment.
Took me a while to understand why it wasn't alphabetized any more... now I see it. Hah!
lib/Sema/ResilienceDiagnostics.cpp
Outdated
| diagnose(D, diag::resilience_decl_declared_here_versioned, | ||
| D->getDescriptiveKind(), D->getFullName()); | ||
| } | ||
| diagnose(D, diag::resilience_decl_declared_here, |
There was a problem hiding this comment.
This change is incorrect; default arguments must only reference true-public things because we want to print that in generated interfaces.
There was a problem hiding this comment.
This change only affects the wording in the diagnostic - you could already reference usableFromInline things. We don’t serialize Exprs so there’s nothing to print, and a common complaint when we rolled out the default argument change was people wanted to reference non-public things. What do you think?
|
I’ll fix the other comments and drop the default argument change for now. We can discuss it separately. |
…rsioned Just parse these as @inlinable and @versioned, then emit a warning (Swift 4.2 and below) or error (Swift 5).
|
@swift-ci Please smoke test |
This PR renames the attributes to their final names, but not does not yet add the change where
@inlinableimplies@usableFromInlinewhen applied to aninternaldeclaration. I'd like to make that change in the next PR and test the renaming on its own.