Add local types to SourceFile when type checking and not when parsing #15619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we end up adding phantom declarations that don't get erased when we backtrack. Fixes <https://bugs.swift.org/browse/SR-7283>, <rdar://problem/38913395>.
|
@swift-ci Please smoke test |
|
Ok, looks like typeCheckDecl() is too late for this. |
DougGregor
approved these changes
Mar 30, 2018
|
#21487 fixes this particular crash. But still, we really want to eliminate side-effects in Parser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we end up adding phantom declarations that
don't get erased when we backtrack.
Fixes https://bugs.swift.org/browse/SR-7283,
rdar://problem/38913395.