Skip to content

Full IRGen support for begin_access [no_nested_conflict]. #15659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2018
Merged

Full IRGen support for begin_access [no_nested_conflict]. #15659

merged 1 commit into from
Apr 1, 2018

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Mar 31, 2018

Suppress generation of the endAccess runtime call when the
begin_access was a "non-tracking" access.

@atrick
Copy link
Contributor Author

atrick commented Mar 31, 2018

@swift-ci smoke test.

Suppress generation of the endAccess runtime call when the
begin_access was a "non-tracking" access.
@atrick
Copy link
Contributor Author

atrick commented Mar 31, 2018

@swift-ci smoke test.

@atrick
Copy link
Contributor Author

atrick commented Mar 31, 2018

@devincoughlin You'll need this if you want to use [no_nested_conflict] for keypaths.

@atrick atrick requested a review from devincoughlin March 31, 2018 23:47
Copy link
Contributor

@devincoughlin devincoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atrick atrick merged commit ba58d3c into swiftlang:master Apr 1, 2018
@atrick atrick deleted the irgen-endaccess branch May 2, 2018 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants