[WIP] Everybody gets a tracer #15665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graydon
force-pushed
the
everybody-gets-a-tracer
branch
2 times, most recently
from
6c011ad to
d24402d
Compare
graydon
force-pushed
the
everybody-gets-a-tracer
branch
from
d24402d to
365effe
Compare
graydon
force-pushed
the
everybody-gets-a-tracer
branch
from
6372944 to
9896b1b
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
graydon
force-pushed
the
everybody-gets-a-tracer
branch
from
9896b1b to
d4022e3
Compare
graydon
force-pushed
the
everybody-gets-a-tracer
branch
from
d4022e3 to
388e357
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
Build failed |
|
Build failed |
DougGregor
approved these changes
Sep 4, 2018
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been dragging on for .. a while .. but I think it's probably worth merging now. The punchline is that every request (in the request-evaluator sense) now gets traced/profiled automatically, and a fair quantity of their arguments do too. I also sprinkled a few others around places I thought might be interesting, expanded the entity vocabulary, and improved the formatting of entity names where possible. The trace logs and profiles are roughly readable/informative now.
(I tried to do quite a lot of template-metaprogram tricks to cut down on the number of explicit overloads and specializations relative to the vocabulary here, all of them either failed in some resolution-ordering corner case I couldn't figure out, or else broke the layering-violation-avoidance tricks, so wouldn't link. I'm happy enough with this state.)