SE-0193: Public default argument generators cannot reference declarations that are @usableFromInline #15666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DougGregor @jrose-apple Can you two decide if we're taking this change, or if we're going to only allow public functions to be referenced from default arguments? |
|
I still would say no but I defer to @DougGregor (including @DougGregor deciding either the core team or the forums needs to discuss it). |
|
The patch looks good, but I feel like we need core team approval to go ahead and merge it. I'll add it to the agenda for the upcoming meeting. |
DougGregor
requested changes
Apr 4, 2018
slavapestov
force-pushed
the
se-0193-default-args
branch
from
b753e55 to
121288c
Compare
slavapestov
changed the title
slavapestov
force-pushed
the
se-0193-default-args
branch
from
121288c to
9ca34c8
Compare
…ine references are allowed For now, always true, soon, default arguments of public functions will return false here.
slavapestov
force-pushed
the
se-0193-default-args
branch
from
9ca34c8 to
9cc1a50
Compare
…ions that are @usableFromInline
slavapestov
force-pushed
the
se-0193-default-args
branch
from
9cc1a50 to
96901f1
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
jrose-apple
approved these changes
Apr 6, 2018
|
@swift-ci Please test source compatibility |
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Jul 11, 2023
The restriction that default arguments be disallowed from accessing `@usableFromInline` decls is overbearing for library developers who need to write non-trivial code to compute a default value, since it forces them to either write a verbose closure inline in the function signature or expose a `public` helper function which unnecessarily expands API surface. A `@usableFromInline` function a more reasonable way to encapsulate a verbose default value computation. This reverses the semantic changes included in swiftlang#15666. Resolves rdar://112093794.
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Jul 12, 2023
The restriction that default arguments be disallowed from accessing `@usableFromInline` decls is overbearing for library developers who need to write non-trivial code to compute a default value, since it forces them to either write a verbose closure inline in the function signature or expose a `public` helper function which unnecessarily expands API surface. A `@usableFromInline` function a more reasonable way to encapsulate a verbose default value computation. This reverses the semantic changes included in swiftlang#15666. Resolves rdar://112093794.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor resilience diagnostics to enforce more restrictions on default argument expressions of public functions. They can only reference other public declarations, and not @usableFromInline declarations.
This is a source-breaking change from Swift 4.1, where public default argument expressions could reference @_versioned declarations; hopefully nobody relied on that, but it would be easy enough to add an
isSwiftVersionAtLeast(5)check in there if we have to.