LargeLoadableTypes: Support applies of objc applies #15693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where we have an apply of an AppleSite that returns a large type. Normally, we should change the ‘apply’ to one that returns @out of the large type. This, however, does not hold true if the ApplySite got the old calling conventions - detect and avoid changing that case.
|
@swift-ci Please test |
aschwaighofer
approved these changes
Apr 3, 2018
There was a problem hiding this comment.
LGTM
Suggestion for improvement (not for this commit):
- It would be nice to be able to dump the SIL before and after this pass (you could add cl::opt flag to do this). This would help debugging these (
sil-print-allis more of a pain to look at) and more importantly we could write tests that FileCheck the out put of this pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
radar rdar://problem/39036867
Fixes a bug where we have an apply of an AppleSite that returns a large type.
Normally, we should change the ‘apply’ to one that returns @out of the large type.
This, however, does not hold true if the ApplySite got the old calling conventions - detect and avoid changing that case.