Skip to content

[Parse] Factor out declaration modifier list parsing #15702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2018
Merged

[Parse] Factor out declaration modifier list parsing #15702

merged 1 commit into from
Apr 3, 2018

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Apr 3, 2018

  • Factor out declaration modifier list parsing (parseDeclModifierList()). This improves readability.
  • Make all libSyntax Decl nodes to hold ModifierList instead of single DeclModifier. Previously, final private class Foo {} used to emit UnknownDecl. The parser parses all possible modifiers first, and diagnose them later.

@rintaro
Copy link
Member Author

rintaro commented Apr 3, 2018

@swift-ci Please smoke test

@rintaro
Copy link
Member Author

rintaro commented Apr 3, 2018

CC: @nkcsgexi @harlanhaskins

@rintaro rintaro merged commit 18b28b9 into swiftlang:master Apr 3, 2018
@rintaro rintaro deleted the parse-modifierlist branch April 3, 2018 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rintaro