stdlib: Collapse some multi-line closures to single-line closures. #15730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in CheckMutableCollectionType.swift.gyb previously resulted in a runtime failure, and before that a compiler crash. It appears that whatever type checker bug(s) were causing the issue have been resolved in the last few months, so I'm returning this closure to a single-expression form and cleaning up a couple other places where we had an unneeded temporary as well. Resolves rdar://problem/33781464.
|
@swift-ci Please smoke test |
xedin
reviewed
Apr 4, 2018
slavapestov
reviewed
Apr 4, 2018
| @@ -446,8 +446,7 @@ self.test("\(testNamePrefix)._withUnsafeMutableBufferPointerIfSupported()/semant | |||
| var c = makeWrappedCollection(test.collection) | |||
| var result = c._withUnsafeMutableBufferPointerIfSupported { | |||
| (bufferPointer) -> OpaqueValue<Array<OpaqueValue<Int>>> in | |||
| let value = OpaqueValue(bufferPointer.map(extractValue)) | |||
| return value | |||
| return OpaqueValue(bufferPointer.map(extractValue)) | |||
There was a problem hiding this comment.
N.B. This is still not a single expression closure though, because it has a return statement.
There was a problem hiding this comment.
@slavapestov These are still considered to be single expression closures.
There was a problem hiding this comment.
Like everyone else on the team, I am still learning Swift. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in
CheckMutableCollectionType.swift.gybpreviously resultedin a runtime failure, and before that a compiler crash.
It appears that whatever type checker bug(s) were causing the issue
have been resolved in the last few months, so I'm returning this
closure to a single-expression form and cleaning up a couple other
places where we had an unneeded temporary as well.
Resolves rdar://problem/33781464.