[SR-7342] Teach EmitImportedModules action to evaluate conditional co… #15739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
AFAICT no other callers of |
jrose-apple
reviewed
Apr 4, 2018
test/Driver/imported_modules.swift
Outdated
|
|
||
| #if canImport(Swift) // To wit, true | ||
| import Swift | ||
| #endif |
There was a problem hiding this comment.
Can you include a condition that's false, too?
benlangmuir
reviewed
Apr 4, 2018
|
Tests passed, added two false conditional tests, holding for @huonw |
huonw
approved these changes
Apr 4, 2018
|
@swift-ci please smoke test and merge |
|
Oh boy, here I go yelling at CI again @swift-ci please smoke test |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mpilation blocks.
Missed this while implementing SE-0075. Will need to cherry-pick this into 4.2 as well.
Resolves SR-7342.