Skip to content

SIL Deserializer: Don't deserialize during "lowered" stage. #15766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jckarter
Copy link
Contributor

@jckarter jckarter commented Apr 5, 2018

Pre-IRGen lowering passes take SIL out of canonical form, making it potentially incompatible with the serialized canonical SIL.

rdar://problem/39211830

…tage.

Pre-IRGen lowering passes take SIL out of canonical form, making it potentially incompatible with the serialized canonical SIL.
@jckarter
Copy link
Contributor Author

jckarter commented Apr 5, 2018

@slavapestov As you requested…

@jckarter
Copy link
Contributor Author

jckarter commented Apr 5, 2018

@swift-ci Please test

@jckarter
Copy link
Contributor Author

jckarter commented Apr 5, 2018

@swift-ci Please test source compatibility

@gottesmm
Copy link
Contributor

gottesmm commented Apr 5, 2018

@jckarter Is there a serialization check as well? If not, we should consider adding one.

@swift-ci
Copy link
Contributor

swift-ci commented Apr 5, 2018

Build failed
Swift Test Linux Platform
Git Sha - 8cf2d90

@swift-ci
Copy link
Contributor

swift-ci commented Apr 5, 2018

Build failed
Swift Test OS X Platform
Git Sha - 8cf2d90

@jckarter jckarter changed the title SIL Deserializer: Assert that we don't deserialize during "lowered" stage. (WIP) SIL Deserializer: Assert that we don't deserialize during "lowered" stage. Apr 5, 2018
@jckarter
Copy link
Contributor Author

jckarter commented Apr 5, 2018

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 5, 2018

Build failed
Swift Test OS X Platform
Git Sha - 8cf2d90

@swift-ci
Copy link
Contributor

swift-ci commented Apr 5, 2018

Build failed
Swift Test Linux Platform
Git Sha - 8cf2d90

@jckarter jckarter changed the title (WIP) SIL Deserializer: Assert that we don't deserialize during "lowered" stage. SIL Deserializer: Don't deserialize during "lowered" stage. Apr 5, 2018
@jckarter jckarter merged commit 78899a5 into swiftlang:master Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants