[Driver] NFC: Add some "const"s to clarify the code. #15769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
jrose-apple
approved these changes
Apr 5, 2018
jrose-apple
reviewed
Apr 5, 2018
include/swift/Driver/Compilation.h
Outdated
|
|
||
| /// Provides a randomization seed to batch-mode partitioning, for debugging. | ||
| unsigned BatchSeed; | ||
| const unsigned BatchSeed; | ||
|
|
||
| /// In order to test repartitioning, set to true if | ||
| /// -driver-force-one-batch-repartition is present. This is cleared after the | ||
| /// forced repartition happens. |
There was a problem hiding this comment.
Oops, looks like the comment didn't get updated for the final approach.
There was a problem hiding this comment.
Thanks--great catch! I guess this const'ing already found one bogus comment.
davidungar
force-pushed
the
PR-18-20-driver-consts
branch
from
27df976 to
906e1ca
Compare
|
@swift-ci smoke test and merge |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All this PR does is add some "const"s to existing declarations. It is a tiny first step to improving the malleability of the driver.