[func-sig-opts] hasNonTrivialNonDebugUse => hasNonTrivialNonDebugTran… #15777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gottesmm
force-pushed
the
pr-bb748720540ac4e06fad7d37623faa9c10bb2599
branch
2 times, most recently
from
b317b19 to
77d36ea
Compare
|
@swift-ci smoke test and merge |
…sitiveUsers and move to DebugUtils. I am getting rid of FunctionSignatureOptUtils. It is only used by FunctionSignatureOpts, so it should either be a local utility file whose header lives in ./lib or integrated into FunctionSignatureOpts. Beyond this utility function (which seems like a generally useful thing that should be in DebugUtils), the only other thing left in FunctionSignatureOptUtils is part of the heuristic of FunctionSignatureOpts. It should really be in that file. rdar://38196046
gottesmm
force-pushed
the
pr-bb748720540ac4e06fad7d37623faa9c10bb2599
branch
from
77d36ea to
88bc490
Compare
|
Fixed a thinko |
|
@swift-ci smoke test and merge |
3 similar comments
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
macOS failure was java build infrastructure related. Lets try this again... |
|
@swift-ci smoke test os x platform |
|
@swift-ci smoke test macOS platform |
|
@swift-ci Please smoke test OS X platform |
3 similar comments
|
@swift-ci Please smoke test OS X platform |
|
@swift-ci Please smoke test OS X platform |
|
@swift-ci Please smoke test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sitiveUsers and move to DebugUtils.
I am getting rid of FunctionSignatureOptUtils. It is only used by
FunctionSignatureOpts, so it should either be a local utility file whose header
lives in ./lib or integrated into FunctionSignatureOpts. Beyond this utility
function (which seems like a generally useful thing that should be in
DebugUtils), the only other thing left in FunctionSignatureOptUtils is part of
the heuristic of FunctionSignatureOpts. It should really be in that file.
rdar://38196046