[sourcekitd] Capture diagnostics with invalid locations for compile notifications #15782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
nathawes
approved these changes
Apr 6, 2018
| continue; | ||
| unsigned Offset = SM.getLocOffsetInBuffer(F.getRange().getStart(), | ||
| BufferID); | ||
| *BufferID); | ||
| unsigned Length = F.getRange().getByteLength(); | ||
| SKInfo.Fixits.push_back({ Offset, Length, F.getText() }); | ||
| } |
There was a problem hiding this comment.
I'm not sure this makes much difference, so up to you, but I thought the above might be more readable with a top-level if (BufferId) { check for non-input buffer, set filename + offset + ranges + fixits } else { set unknown filename }
There was a problem hiding this comment.
Ah, good point. I'll do that.
…otifications Stop filtering out diagnostics with invalid locations in the editor diagnostic consumer, and instead capture them separately so that we can include them in did-compile notifications. rdar://39225000
benlangmuir
force-pushed
the
invalid-diag-loc-note
branch
from
407de49 to
969f0f4
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop filtering out diagnostics with invalid locations in the editor diagnostic consumer, and instead capture them separately so that we can include them in did-compile notifications.
rdar://39225000