Skip to content

TBDGen: Add resilient enum case emission support #15795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2018

Conversation

aschwaighofer
Copy link
Contributor

rdar://38707747

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please smoke test and merge

@aschwaighofer aschwaighofer requested a review from huonw April 6, 2018 18:59
@swift-ci swift-ci merged commit e07f047 into swiftlang:master Apr 6, 2018
@@ -299,6 +299,17 @@ void TBDGenVisitor::visitProtocolDecl(ProtocolDecl *PD) {
#endif
}

void TBDGenVisitor::visitEnumDecl(EnumDecl *ED) {
if (!ED->isResilient(SwiftModule, ResilienceExpansion::Minimal))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just isResilient(). The module you're supposed to pass is the client module, not the library module, but ResilienceExpansion::Minimal makes that uninteresting anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like so: #15799

@huonw
Copy link
Contributor

huonw commented Apr 8, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants